balsoft/ligo
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Validator: better error message for operations that exceed max size

Browse Source
This commit is contained in:
Milo Davis 2017-10-10 14:03:44 +02:00
parent b5e53191e2
commit dc74acba56
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/proto/alpha/operation_repr.ml
View File

@ -327,6 +327,7 @@ module Encoding = struct
end end
type error += Cannot_parse_operation type error += Cannot_parse_operation
type error += Operation_exceeds_max_length of int
let encoding = let encoding =
let open Data_encoding in let open Data_encoding in
@ -352,11 +353,23 @@ let () =
Format.fprintf ppf "The operation cannot be parsed") Format.fprintf ppf "The operation cannot be parsed")
Data_encoding.unit Data_encoding.unit
(function Cannot_parse_operation -> Some () | _ -> None) (function Cannot_parse_operation -> Some () | _ -> None)
(fun () -> Cannot_parse_operation) (fun () -> Cannot_parse_operation) ;
register_error_kind
`Branch
~id:"operationExceedsMaxLength"
~title:"Operation exceeded maximum allowed operation length"
~description:"The operation exceeded the maximum allowed length of an operation."
~pp:(fun ppf len ->
Format.fprintf ppf
"The operation was %d bytes, but operations must be less than %d bytes."
len Constants_repr.max_operation_data_length)
Data_encoding.(obj1 (req "length" int31))
(function Operation_exceeds_max_length len -> Some len | _ -> None)
(fun len -> Operation_exceeds_max_length len)
let parse hash (op: Operation.t) = let parse hash (op: Operation.t) =
if not (Compare.Int.(MBytes.length op.proto <= Constants_repr.max_operation_data_length)) then if not (Compare.Int.(MBytes.length op.proto <= Constants_repr.max_operation_data_length)) then
error Cannot_parse_operation error (Operation_exceeds_max_length (MBytes.length op.proto))
else else
match Data_encoding.Binary.of_bytes match Data_encoding.Binary.of_bytes
Encoding.signed_proto_operation_encoding Encoding.signed_proto_operation_encoding