From 10eebf69bd98c320810a7f8dad277014271e076b Mon Sep 17 00:00:00 2001
From: Tom Jack <tom@tomjack.co>
Date: Mon, 6 Jan 2020 14:19:14 -0600
Subject: [PATCH] Support always-failing conditionals

---
 src/bin/expect_tests/contract_tests.ml        | 24 +++++++++++++++++++
 src/main/run/of_michelson.ml                  |  4 ++--
 src/passes/9-self_michelson/self_michelson.ml | 19 ++++++++++++++-
 src/test/contracts/subtle_nontail_fail.mligo  |  4 ++++
 4 files changed, 48 insertions(+), 3 deletions(-)
 create mode 100644 src/test/contracts/subtle_nontail_fail.mligo

diff --git a/src/bin/expect_tests/contract_tests.ml b/src/bin/expect_tests/contract_tests.ml
index 80ff203ec..35bb1bc3b 100644
--- a/src/bin/expect_tests/contract_tests.ml
+++ b/src/bin/expect_tests/contract_tests.ml
@@ -1012,3 +1012,27 @@ let%expect_test _ =
 let%expect_test _ =
     run_ligo_good [ "dry-run" ; contract "double_main.ligo" ; "main" ; "unit" ; "0" ] ;
     [%expect {|( [] , 2 ) |}]
+
+let%expect_test _ =
+  run_ligo_good [ "compile-contract" ; contract "subtle_nontail_fail.mligo" ; "main" ] ;
+  [%expect {|
+    { parameter unit ;
+      storage unit ;
+      code { PUSH bool True ;
+             IF { PUSH string "This contract always fails" ; FAILWITH }
+                { PUSH string "This contract still always fails" ; FAILWITH } } } |}]
+
+let%expect_test _ =
+  (* TODO should not be bad? *)
+  run_ligo_bad [ "dry-run" ; contract "subtle_nontail_fail.mligo" ; "main" ; "()" ; "()" ] ;
+  [%expect {|
+    ligo: error of execution
+
+     If you're not sure how to fix this error, you can
+     do one of the following:
+
+    * Visit our documentation: https://ligolang.org/docs/intro/what-and-why/
+    * Ask a question on our Discord: https://discord.gg/9rhYaEt
+    * Open a gitlab issue: https://gitlab.com/ligolang/ligo/issues/new
+    * Check the changelog by running 'ligo changelog' |}]
+
diff --git a/src/main/run/of_michelson.ml b/src/main/run/of_michelson.ml
index 1a3b58114..03543a5c0 100644
--- a/src/main/run/of_michelson.ml
+++ b/src/main/run/of_michelson.ml
@@ -103,7 +103,7 @@ let run_contract ?options (exp:Michelson.t) (exp_type:ex_ty) (input_michelson:Mi
   let exp = Michelson.strip_annots exp in
   let%bind descr =
     Trace.trace_tzresult_lwt (simple_error "error parsing program code") @@
-    Memory_proto_alpha.parse_michelson ~top_level exp ty_stack_before ty_stack_after in
+    Memory_proto_alpha.parse_michelson_fail ~top_level exp ty_stack_before ty_stack_after in
   let open! Memory_proto_alpha.Protocol.Script_interpreter in
   let%bind (Item(output, Empty)) =
     Trace.trace_tzresult_lwt (simple_error "error of execution") @@
@@ -120,7 +120,7 @@ let run_expression ?options (exp:Michelson.t) (exp_type:ex_ty) : run_res result
   and ty_stack_after = Script_typed_ir.Item_t (exp_type', Empty_t, None) in
   let%bind descr =
     Trace.trace_tzresult_lwt (simple_error "error parsing program code") @@
-    Memory_proto_alpha.parse_michelson ~top_level exp ty_stack_before ty_stack_after in
+    Memory_proto_alpha.parse_michelson_fail ~top_level exp ty_stack_before ty_stack_after in
   let open! Memory_proto_alpha.Protocol.Script_interpreter in
   let%bind res =
     Trace.trace_tzresult_lwt (simple_error "error of execution") @@
diff --git a/src/passes/9-self_michelson/self_michelson.ml b/src/passes/9-self_michelson/self_michelson.ml
index 12b8073aa..19fe58476 100644
--- a/src/passes/9-self_michelson/self_michelson.ml
+++ b/src/passes/9-self_michelson/self_michelson.ml
@@ -359,13 +359,30 @@ let opt_swap2 : peep2 = function
    thwarting the intent of the Michelson tail fail restriction -- the
    LIGO _user_ might accidentally write dead code immediately after a
    failure, and we will simply erase it. *)
+let rec is_failing : michelson -> bool =
+  function
+  | Seq (_, []) -> false
+  | Seq (_, [arg]) -> is_failing arg
+  | Seq (l, _ :: args) -> is_failing (Seq (l, args))
+  | Prim (_, I_FAILWITH, _, _) -> true
+  | Prim (_, I_IF, [bt; bf], _)
+  | Prim (_, I_IF_CONS, [bt; bf], _)
+  | Prim (_, I_IF_LEFT, [bt; bf], _)
+  | Prim (_, I_IF_NONE, [bt; bf], _) ->
+    is_failing bt && is_failing bf
+  (* Note: the body of ITER, LOOP, LOOP_LEFT _can_ be
+     failing. However, the loop will _not_ be failing, because the
+     body might never be executed. The body of MAP _cannot_ be
+     failing. *)
+  | _ -> false
+
 let rec opt_tail_fail : michelson -> michelson =
   function
   | Seq (l, args) ->
      let rec aux args =
        match args with
        | [] -> []
-       | Prim (l, I_FAILWITH, args, annot) :: _ -> [ Prim (l, I_FAILWITH, args, annot) ]
+       | arg :: _ when is_failing arg -> [arg]
        | arg :: args -> arg :: aux args in
      let args = aux args in
      Seq (l, List.map opt_tail_fail args)
diff --git a/src/test/contracts/subtle_nontail_fail.mligo b/src/test/contracts/subtle_nontail_fail.mligo
new file mode 100644
index 000000000..107dbdb1e
--- /dev/null
+++ b/src/test/contracts/subtle_nontail_fail.mligo
@@ -0,0 +1,4 @@
+let main (ps : unit * unit) =
+  if true
+  then failwith "This contract always fails"
+  else failwith "This contract still always fails"