From 41fe7d17ea322ad6c99208ac5ae24f32efe324b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gr=C3=A9goire=20Henry?= <gregoire.henry@tezos.com>
Date: Tue, 17 Jul 2018 14:23:19 +0200
Subject: [PATCH] Node: check that the size of `known_peer_ids` is coherent

---
 src/bin_node/node_config_file.ml | 44 ++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/src/bin_node/node_config_file.ml b/src/bin_node/node_config_file.ml
index e6ae198cd..5c15ea2fe 100644
--- a/src/bin_node/node_config_file.ml
+++ b/src/bin_node/node_config_file.ml
@@ -731,8 +731,52 @@ let check_bootstrap_peer addr =
 let check_bootstrap_peers config =
   Lwt_list.iter_p check_bootstrap_peer config.p2p.bootstrap_peers
 
+
+let fail fmt =
+  Format.kasprintf (fun s -> prerr_endline s ; exit 1) fmt
+
+let check_connections config =
+  if config.p2p.limits.min_connections > config.p2p.limits.expected_connections then
+    fail "Error: The minumum number of connections is greater than \
+          the expected number of connections"
+      config.p2p.limits.min_connections
+      config.p2p.limits.expected_connections ;
+  if config.p2p.limits.expected_connections > config.p2p.limits.max_connections then
+    fail "Error: The expected number of connections is greater than \
+          the maximum number of connections"
+      config.p2p.limits.expected_connections
+      config.p2p.limits.max_connections ;
+  begin
+    match config.p2p.limits.max_known_peer_ids with
+    | None -> ()
+    | Some (max_known_peer_ids, target_known_peer_ids) ->
+        if target_known_peer_ids > max_known_peer_ids then
+          fail "Error: The target number of known peer ids is greater than \
+                the maximum number of known peer ids."
+            target_known_peer_ids max_known_peer_ids ;
+        if config.p2p.limits.max_connections > target_known_peer_ids then
+          fail "Error: The target number of known peer ids is lower than \
+                the maximum number of connections."
+            target_known_peer_ids max_known_peer_ids ;
+  end ;
+  begin
+    match config.p2p.limits.max_known_points with
+    | None -> ()
+    | Some (max_known_points, target_known_points) ->
+        if target_known_points > max_known_points then
+          fail "Error: The target number of known points is greater than \
+                the maximum number of known points."
+            target_known_points max_known_points ;
+        if config.p2p.limits.max_connections > target_known_points then
+          fail "Error: The target number of known points is lower than \
+                the maximum number of connections."
+            target_known_points max_known_points ;
+  end
+
+
 let check config =
   check_listening_addr config >>= fun () ->
   check_rpc_listening_addr config >>= fun () ->
   check_bootstrap_peers config >>= fun () ->
+  check_connections config ;
   Lwt.return_unit